Skip to content

Exclude Content-Transfer-Encoding decoding from the threat model - #367

Merged
Kludex merged 2 commits into
mainfrom
clarify-cte-threat-model
Nov 16, 2026
Merged

Kludex merged 2 commits into
mainfrom
clarify-cte-threat-model

Conversation

@Kludex

@Kludex Kludex commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

The threat model counts any specification departure that changes a value as a vulnerability. That includes Content-Transfer-Encoding decoding bugs, which keep arriving as security reports.

RFC 7578 §4.7 deprecates Content-Transfer-Encoding for multipart/form-data, and browsers do not send it. A value that is not decoded still holds the bytes the client sent. This adds it to "What does not count", so these go to public issues instead.

Session: pi --session 01a1cc04-bb37-7152-92e5-03b3625b499e

View guided diff

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T20:24:08.448799Z dbd4e0b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Re-trigger cubic

@Kludex
Kludex enabled auto-merge (squash) November 11, 2026 20:29
@Kludex Kludex closed this Nov 11, 2026
auto-merge was automatically disabled November 11, 2026 20:45

Pull request was closed

@Kludex Kludex reopened this Nov 11, 2026
@codspeed

codspeed Bot commented Nov 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks


Comparing clarify-cte-threat-model (cfe2f3f) with main (6cebfd8)

Open in CodSpeed

@Kludex
Kludex merged commit c511ff0 into main Nov 16, 2026
14 checks passed
@Kludex
Kludex deleted the clarify-cte-threat-model branch November 16, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant