Repository navigation
Exclude Content-Transfer-Encoding decoding from the threat model - #367
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Kludex
enabled auto-merge (squash)
November 11, 2026 20:29
auto-merge was automatically disabled
November 11, 2026 20:45
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The threat model counts any specification departure that changes a value as a vulnerability. That includes
Content-Transfer-Encodingdecoding bugs, which keep arriving as security reports.RFC 7578 §4.7 deprecates
Content-Transfer-Encodingformultipart/form-data, and browsers do not send it. A value that is not decoded still holds the bytes the client sent. This adds it to "What does not count", so these go to public issues instead.Session:
pi --session 01a1cc04-bb37-7152-92e5-03b3625b499e